RPC: Add inner instructions to simulate transaction response #34313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
solflare-rpc-simulate
branch
3 times, most recently
from
8b59c17 to
573b827
Compare
buffalojoec
force-pushed
the
solflare-rpc-simulate
branch
2 times, most recently
from
b726d73 to
a888af0
Compare
buffalojoec
force-pushed
the
solflare-rpc-simulate
branch
3 times, most recently
from
3c1e30f to
c24d74f
Compare
buffalojoec
added
the
do-not-close
buffalojoec
force-pushed
the
solflare-rpc-simulate
branch
3 times, most recently
from
e974a2a to
ad2e601
Compare
buffalojoec
force-pushed
the
solflare-rpc-simulate
branch
from
ad2e601 to
ddc8144
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34313 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 819 820 +1
Lines 220889 220905 +16
=========================================
- Hits 180845 180782 -63
- Misses 40044 40123 +79 |
Co-authored-by: Tyera <[email protected]>
buffalojoec
force-pushed
the
solflare-rpc-simulate
branch
from
fe7c680 to
a405a6c
Compare
CriesofCarrots
added
the
automerge
solana-grimes
removed
the
automerge
|
😱 New commits were pushed while the automerge label was present. |
CriesofCarrots
approved these changes
Dec 16, 2023
buffalojoec
added
the
automerge
buffalojoec
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Wallets use transaction simulation to notify users about the contents of a transaction before they apply their signature. This is the primary method by which wallets, and potentially other dApps and infrastructure, detect malicious instructions.
Currently, transaction simulation offers the ability to observe the resulting account state for various account keys provided and transaction logs. However, it would provide even more enhanced security for Solana users if transaction simulation also returned the parsed inner instructions of a transaction.
Summary of Changes
The RPC change includes adding an optional parameter -
innerInstructions: bool- tosimulateTransaction, and addingjsonParsedinner instructions to the response type ifinnerInstructionsis provided astrue. Similar togetTransaction, if the instruction cannot be parsed withjsonParsed, it defaults tojson, where thedatafield is base58 encoded.This change also required the bank to return
inner_instructionsfrom itssimulate_transactionmethod.